Complete CCPPization of Beljaars orographic form drag scheme#396
Conversation
JulioTBacmeister
left a comment
JulioTBacmeister
left a comment
There was a problem hiding this comment.
Looks better than the original
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @jimmielin! I have some requests, but they should hopefully all be simple to implement (and of course if not please let me know)!
| <!-- Beljaars SGO form drag --> | ||
| <scheme>beljaars_drag</scheme> | ||
| <scheme>beljaars_drag_diagnostics</scheme> |
There was a problem hiding this comment.
Can we add Beljaars to the CAM5 and CAM7 suites as well?
There was a problem hiding this comment.
Thanks, added to the two suites.
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for responding to my requests and questions @jimmielin! I just had one last (optional) request, but nothing that should hold up this PR. Thanks again!
There was a problem hiding this comment.
Do we still need this commented-out scheme in the SDF?
There was a problem hiding this comment.
Yes I do, thank you for spotting this! Added now that Beljaars is in the CAM5 suite.
atmos_phys0_24_000: Complete CCPPization of Beljaars orographic form drag scheme (ESCOMP#396)
5 participants
Tag name (The PR title should also include the tag name):
Originator(s):
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
List all namelist files that were added or changed:
A schemes/beljaars_drag/beljaars_drag_namelist.xml
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status main...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed:
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
No
New physics package, CAM regression tests, CAM-SIMA snapshot all pass
If yes to the above question, describe how this code was validated with the new/modified features: